Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - Improve Minikube source code copy process #367

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 22, 2018

This change is Reviewable

@IronPan
Copy link
Member

IronPan commented Nov 22, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun Ark-kun force-pushed the avolkov/Tests---Improve-Minikube-source-code-copy-process branch from 3525019 to e2d9a20 Compare November 22, 2018 09:51
@Ark-kun Ark-kun changed the title Tests - Improve Minikube source code copy process [WIP] Tests - Improve Minikube source code copy process Nov 22, 2018
@Ark-kun Ark-kun changed the title [WIP] Tests - Improve Minikube source code copy process Tests - Improve Minikube source code copy process Nov 23, 2018
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 27, 2018

@IronPan Can you please re-lgtm?

@IronPan
Copy link
Member

IronPan commented Nov 27, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 81f2df6 into master Nov 27, 2018
@Ark-kun Ark-kun deleted the avolkov/Tests---Improve-Minikube-source-code-copy-process branch November 28, 2018 17:36
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
…kf-releasing. (kubeflow#367)

* Create Kubeflow cluster in project: kf-releasing.

* This will be used for running cron jobs to periodically release our images.

Related to: kubeflow#366 create a v0.5 cluster for releasing.
Fix: kubeflow#43 setup IAP in release cluster.

* exclude release-infra from lint
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants